Accept HMAC key from file #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronborden-rivianvw
changed the title
saracen
reviewed
Aug 11, 2022
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
@aaronborden-rivian Can you run go fmt for this file?
go fmt automatically formats Go files to ensure that they're always consistent. I probably should add a CI linter job to detect this.
Owner
|
@aaronborden-rivian This looks great, there's just one change to make. We should probably update If you'd like to take a stab at this in this PR, you're welcome to do so, but if not, I'll merge this and add the functional options myself before tagging a new release. I should probably update the version of Go used to build the binaries too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
I'm not a golang developer, so hopefully this is close enough to what you're looking for.